Issue 6099057: code review 6099057: vet: check values for named constants as well as literals.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6099057: code review 6099057: vet: check values for named constants as well as literals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

vet: check values for named constants as well as literals. As in: const format = "%s" fmt.Printf(format, "hi") Also fix a couple of bugs by rewriting the routine.

Patch Set 1 #

Patch Set 2 : diff -r a5db0f596a99 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a5db0f596a99 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a5db0f596a99 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -14 lines)			Patch
	M	src/cmd/vet/print.go	View	1 2	3 chunks	+43 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2012-04-25 01:31:49 UTC) #1

12 years ago (2012-04-25 02:15:02 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=29665c4bae69 ***

vet: check values for named constants as well as literals.
As in:
        const format = "%s"
        fmt.Printf(format, "hi")
Also fix a couple of bugs by rewriting the routine.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6099057

Expand All Messages | Collapse All Messages