Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(642)

Issue 6099052: HttpResponseException.getStatusMessage() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rmistry
Modified:
11 years, 11 months ago
Reviewers:
yanivi
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Fix for http://code.google.com/p/google-http-java-client/issues/detail?id=93 : Add HttpResponseException.getStatusMessage()

Patch Set 1 #

Patch Set 2 : Minor fix #

Total comments: 6

Patch Set 3 : Addressing code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java View 1 2 5 chunks +26 lines, -2 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rmistry
11 years, 11 months ago (2012-04-24 17:54:41 UTC) #1
yanivi
http://codereview.appspot.com/6099052/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java (right): http://codereview.appspot.com/6099052/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#newcode32 google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:32: private int statusCode; final http://codereview.appspot.com/6099052/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#newcode85 google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:85: public boolean isSuccessStatusCode() ...
11 years, 11 months ago (2012-04-25 14:01:36 UTC) #2
rmistry
http://codereview.appspot.com/6099052/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java (right): http://codereview.appspot.com/6099052/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#newcode32 google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:32: private int statusCode; On 2012/04/25 14:01:36, yanivi wrote: > ...
11 years, 11 months ago (2012-04-25 15:49:29 UTC) #3
yanivi
11 years, 11 months ago (2012-04-26 17:28:58 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b