Issue 6099046: Document "fingerings" being frets rather than fingers for fretted instruments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6099046: Document "fingerings" being frets rather than fingers for fretted instruments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by dak

Modified:
13 years ago

Reviewers:
carl.d.sorensen, Trevor Daniels

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Document "fingerings" being frets rather than fingers for fretted instruments.

Patch Set 1 #

Total comments: 3

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Documentation/notation/fretted-strings.itely	View		1 chunk	+4 lines, -1 line	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Trevor Daniels

One nitpick; otherwise LGTM http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely#newcode68 Documentation/notation/fretted-strings.itely:68: when assigning strings, this distinction ...

13 years ago (2012-04-22 20:03:55 UTC) #1

Carl

I believe that this is wrong -- fingerings are fingers for fretted instruments, not frets. ...

13 years ago (2012-04-22 21:03:12 UTC) #2

dak

13 years ago (2012-04-22 22:04:41 UTC) #3

http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:68: when assigning strings, this
distinction is not academical.
On 2012/04/22 21:03:12, Carl wrote:
> I don't think this is true.
> 
> Fingerings specify string and finger; the fret is automatically calculated.
> 
> Tablature notations heed string assignments, which determine frets.  Then
> non-assigned strings try to find frets within a specified reach.
> 
> I think this paragraph is wrong.  If it is right, please create a snippet that
> shows the difference.

The documentation itself contains examples with "finger" 6 6 7 or so: I think it
was me who added them some time ago.  Checking the code, it might indeed be that
the only question asked of the fingering might be "0 or not".  I will
cross-check with actual tablatures tomorrow.

If you are right, the existing examples in the docs need some changes.

Expand All Messages | Collapse All Messages