Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6071043: convert float to SkScalar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by guanqun
Modified:
12 years, 4 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

convert float to SkScalar Though GPU is not used with fixed build, the float should better be wrapped with SkFloatToScalar(). BUG= TEST=

Patch Set 1 #

Patch Set 2 : more in GrContext.cpp #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/gpu/GrContext.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
guanqun
Please review. thanks!
12 years, 4 months ago (2012-04-19 06:03:27 UTC) #1
guanqun
Adding Robert who's doing some fixed pointing fixing lately. Please review, thanks!
12 years, 4 months ago (2012-04-27 04:47:14 UTC) #2
robertphillips
On 2012/04/27 04:47:14, guanqun wrote: > Adding Robert who's doing some fixed pointing fixing lately. ...
12 years, 4 months ago (2012-04-27 12:39:37 UTC) #3
guanqun.lu_gmail.com
Please help land this CL, I don't have the commit permission. Thanks! On Fri, Apr ...
12 years, 4 months ago (2012-04-27 15:02:47 UTC) #4
robertphillips
12 years, 4 months ago (2012-04-27 15:40:21 UTC) #5 
committed as r3779
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b