Issue 6061046: Fix reset of scissor state in onResetContext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6061046: Fix reset of scissor state in onResetContext (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bsalomon

Modified:
12 years, 8 months ago

Reviewers:
robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/gpu/gl/GrGpuGL.cpp	View		2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

robertphillips

12 years, 9 months ago (2012-04-17 16:00:11 UTC) #2

LGTM w/ 1 nit & a question

http://codereview.appspot.com/6061046/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

http://codereview.appspot.com/6061046/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode519
src/gpu/gl/GrGpuGL.cpp:519: // set to false to force disableScissor to make a GL
call.
// set to true

Also, shouldn't the gl scissor state already be guaranteed to be disabled if
fScissorEnabled is false?

Expand All Messages | Collapse All Messages