Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3066)

Issue 6057047: adding glBlendEquation to GL interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Updated MESA, fixed Mac, add 1.4 guard in Native paths #

Total comments: 2

Patch Set 3 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -12 lines) Patch
M include/gpu/gl/GrGLInterface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 2 1 chunk +17 lines, -1 line 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 2 1 chunk +15 lines, -1 line 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 2 1 chunk +15 lines, -1 line 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M src/gpu/ios/GrGLDefaultInterface_iOS.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
robertphillips
Brian - Apropos our conversation yesterday it looks like all the Native interfaces (except Mac) ...
12 years, 7 months ago (2012-04-18 12:43:35 UTC) #1
bsalomon
I'm fine with requiring OpenGL 1.5+. It's low priority, though, so I wouldn't do it ...
12 years, 7 months ago (2012-04-18 13:54:40 UTC) #2
robertphillips
Fixed EXT issue in all Native interfaces. Altered validate to just insist on glBlendColor & ...
12 years, 7 months ago (2012-04-18 14:24:49 UTC) #3
bsalomon
On 2012/04/18 14:24:49, robertphillips wrote: > Fixed EXT issue in all Native interfaces. > Altered ...
12 years, 7 months ago (2012-04-18 14:32:25 UTC) #4
robertphillips
12 years, 7 months ago (2012-04-18 14:40:35 UTC) #5
committed as r3720
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b