Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 6056044: code review 6056044: libdynld: add plan9ified libdynld to main tree.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by npe
Modified:
13 years, 8 months ago
Reviewers:
rminnich, John Floren, Nixie, charles.forsyth
CC:
nix-dev_googlegroups.com
Visibility:
Public.

Description

libdynld: add plan9ified libdynld to main tree. Libdynld is a library for dynamically loading code into an executable at runtime. See http://www.vitanuova.com/inferno/man/10/dynld.html for more information.

Patch Set 1 #

Patch Set 2 : diff -r bd329fe2476d https://noah.evans@code.google.com/p/nix-os/ #

Patch Set 3 : diff -r bd329fe2476d https://noah.evans@code.google.com/p/nix-os/ #

Patch Set 4 : diff -r bd329fe2476d https://noah.evans@code.google.com/p/nix-os/ #

Patch Set 5 : diff -r bd329fe2476d https://noah.evans@code.google.com/p/nix-os/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -0 lines) Patch
A sys/include/dynld.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A sys/src/libdynld/NOTICE View 1 1 chunk +28 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld.c View 1 1 chunk +259 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-386.c View 1 1 chunk +43 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-68000.c View 1 1 chunk +22 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-arm.c View 1 1 chunk +44 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-mips.c View 1 1 chunk +22 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-power.c View 1 1 chunk +65 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-sparc.c View 1 1 chunk +20 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynld-spim.c View 1 1 chunk +22 lines, -0 lines 0 comments Download
A sys/src/libdynld/dynloadfd.c View 1 1 chunk +36 lines, -0 lines 0 comments Download
A sys/src/libdynld/mkfile View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6
npe
Hello nixiedev@gmail.com, rminnich@gmail.com, charles.forsyth@gmail.com (cc: nix-dev@googlegroups.com), I'd like you to review this change to https://noah.evans@code.google.com/p/nix-os/
13 years, 8 months ago (2012-04-17 09:01:38 UTC) #1
npe
Hello nixiedev@gmail.com, rminnich@gmail.com, charles.forsyth@gmail.com (cc: nix-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2012-04-17 09:31:58 UTC) #2
npe
Hello nixiedev@gmail.com, rminnich@gmail.com, charles.forsyth@gmail.com (cc: nix-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2012-04-17 09:32:32 UTC) #3
John Floren
LGTM, for a brief value of "look" :) On Tue, Apr 17, 2012 at 2:32 ...
13 years, 8 months ago (2012-04-17 15:09:24 UTC) #4
npe
It's not entirely ready yet. It still needs amd64 and it makes a lot of ...
13 years, 8 months ago (2012-04-17 15:12:04 UTC) #5
charles.forsyth_gmail.com
13 years, 8 months ago (2012-04-17 15:51:59 UTC) #6
Why is Reply-to: never what you want?

Anyway: oh, it obviously pre-dated uintptr, by several years in fact.
Um. I'd better check in umpteen places that I didn't subsequently update it
somewhere.

On 17 April 2012 16:11, Noah Evans <noah.evans@gmail.com> wrote:

> It's not entirely ready yet. It still needs amd64 and it makes a lot
> of 32bit assumptions. Charles do you have any pointers on how you
> would do it?
>
> Noah
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b