Issue 6043045: Add coverage AA support for SampleApp root layers (windows only)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6043045: Add coverage AA support for SampleApp root layers (windows only) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : cleanup #

Total comments: 1

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -34 lines)			Patch
M	include/utils/SkWGL.h	View	1	2 chunks	+41 lines, -22 lines	1 comment	Download
M	src/utils/win/SkWGL_win.cpp	View	1	2 chunks	+78 lines, -0 lines	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	1	3 chunks	+20 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM w/ 1 nit http://codereview.appspot.com/6043045/diff/2001/include/utils/SkWGL.h File include/utils/SkWGL.h (right): http://codereview.appspot.com/6043045/diff/2001/include/utils/SkWGL.h#newcode88 include/utils/SkWGL.h:88: * * If the above ...

12 years, 5 months ago (2012-04-16 22:18:33 UTC) #2

Fixed comment, committed as r3703.

Expand All Messages | Collapse All Messages