Issue 6038051: Propagated AA flags through Ganesh's clip stack (in preparation for GL AA clipping)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6038051: Propagated AA flags through Ganesh's clip stack (in preparation for GL AA clipping) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by robertphillips

Modified:
13 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL just gets the AA flag information down to a level where it can be accessed by the A8/R8 AA clipping code. Before it was not being carried all the way down - since it wasn't used.

Patch Set 2 : Addressed code review issues #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -51 lines)			Patch
M	include/core/SkClipStack.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	include/gpu/GrClip.h	View		4 chunks	+8 lines, -1 line	0 comments	Download
M	include/gpu/GrClipIterator.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	include/gpu/SkGr.h	View	1	3 chunks	+10 lines, -48 lines	0 comments	Download
M	src/gpu/GrClip.cpp	View		7 chunks	+11 lines, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

http://codereview.appspot.com/6038051/diff/1/include/gpu/SkGr.h File include/gpu/SkGr.h (right): http://codereview.appspot.com/6038051/diff/1/include/gpu/SkGr.h#newcode113 include/gpu/SkGr.h:113: virtual bool getDoAA() const SK_OVERRIDE; Only real change is ...

13 years, 6 months ago (2012-04-16 12:49:58 UTC) #1

bsalomon

LGTM http://codereview.appspot.com/6038051/diff/1/include/core/SkClipStack.h File include/core/SkClipStack.h (right): http://codereview.appspot.com/6038051/diff/1/include/core/SkClipStack.h#newcode52 include/core/SkClipStack.h:52: Clip() : fRect(NULL), fPath(NULL), fOp(SkRegion::kIntersect_Op), fDoAA(false) {} Might ...

13 years, 6 months ago (2012-04-16 14:38:51 UTC) #2

robertphillips

13 years, 6 months ago (2012-04-16 14:50:03 UTC) #3

committed as r3685

http://codereview.appspot.com/6038051/diff/1/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

http://codereview.appspot.com/6038051/diff/1/include/core/SkClipStack.h#newco...
include/core/SkClipStack.h:52: Clip() : fRect(NULL), fPath(NULL),
fOp(SkRegion::kIntersect_Op), fDoAA(false) {}
On 2012/04/16 14:38:52, bsalomon wrote:
> Might be time to make this multiline

Done.

http://codereview.appspot.com/6038051/diff/1/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

http://codereview.appspot.com/6038051/diff/1/include/gpu/SkGr.h#newcode137
include/gpu/SkGr.h:137: // TODO: remove this (unused) class?
On 2012/04/16 14:38:52, bsalomon wrote:
> On 2012/04/16 12:49:58, robertphillips wrote:
> > Brian?
> 
> Yeah I think we can kill it. We used to build GrClip from SkRegion but it's
been
> a long time and we're not going back.

Done.

Expand All Messages | Collapse All Messages