Issue 6031057: support multiple configs for bench program

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6031057: support multiple configs for bench program (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by guanqun

Modified:
12 years, 6 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

support multiple configs for bench program Our team is only focused on config 8888 and config GPU and most of the time, we want to compare the differences of them two. With this little improvement, we can use the following commands: ./out/Release/bench -config 8888 -config GPU -repeat 1000 to show only those configs that we care about. BUG= TEST=

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
	M	bench/benchmain.cpp	View		4 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TomH

12 years, 6 months ago (2012-04-16 18:01:32 UTC) #2

LGTM.

Thank you, this is very handy. Please close the issue when you get a chance.

Committed as r3696.

Expand All Messages | Collapse All Messages