Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1788)

Issue 6031043: First pass at stencil clip mask refactoring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is just the first pass. TODO: I have left the code in place so that the diff can work at all - I will move it in the next delivery The handling of the scissor rect is still a bit rough but I want to leave it be for now. I had hoped to eliminate the use of the stack to store the scissor rect but it proved problematic. There are some rough edges w.r.t. the invalidation of the HW scissoring bound (I would like to invalidate it more often) and the Apple-specific scissoring handling (I would like to unify it will the enable/disable-Scissoring system). I would like to defer both of these changes until this first pass makes it in.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -210 lines) Patch
M src/gpu/GrGpu.h View 1 7 chunks +71 lines, -20 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 6 chunks +219 lines, -156 lines 0 comments Download
M src/gpu/GrStencil.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 8 chunks +41 lines, -32 lines 0 comments Download

Messages

Total messages: 5
robertphillips
12 years, 7 months ago (2012-04-13 18:04:48 UTC) #1
bsalomon
Overall I like the direction of capturing the clip implementation in its own class. http://codereview.appspot.com/6031043/diff/1/src/gpu/GrGpu.h ...
12 years, 7 months ago (2012-04-16 14:31:45 UTC) #2
robertphillips
http://codereview.appspot.com/6031043/diff/1/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): http://codereview.appspot.com/6031043/diff/1/src/gpu/GrGpu.h#newcode75 src/gpu/GrGpu.h:75: class GrClipMaskCreator { Can we talk about the header/private ...
12 years, 7 months ago (2012-04-16 15:14:12 UTC) #3
bsalomon
On 2012/04/16 15:14:12, robertphillips wrote: > http://codereview.appspot.com/6031043/diff/1/src/gpu/GrGpu.h > File src/gpu/GrGpu.h (right): > > http://codereview.appspot.com/6031043/diff/1/src/gpu/GrGpu.h#newcode75 > ...
12 years, 7 months ago (2012-04-16 16:23:16 UTC) #4
robertphillips
12 years, 7 months ago (2012-04-16 16:33:59 UTC) #5
committed as r3692
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b