range: lean and mean

Lib/test/pickletester.py

 import unittest
 import pickle
 import pickletools
 import copy_reg
 
 from test.test_support import TestFailed, TESTFN, run_with_locale
 
 from pickle import bytes_types
 
 # Tests that try a number of pickle protocols should have a
 #     for proto in protocols:
 # kind of outer loop.
-protocols = range(pickle.HIGHEST_PROTOCOL + 1)
+protocols = list(range(pickle.HIGHEST_PROTOCOL + 1))
 
 
 # Return True if opcode code appears in the pickle, else False.
 def opcode_in_pickle(code, pickle):
     for op, dummy, dummy in pickletools.genops(pickle):
         if op.code == code.decode("latin-1"):
             return True
     return False
 
 # Return the number of times opcode code appears in pickle.
@@ skipping 554 matching lines @@
 
     def test_proto(self):
         build_none = pickle.NONE + pickle.STOP
         for proto in protocols:
             expected = build_none
             if proto >= 2:
                 expected = pickle.PROTO + bytes([proto]) + expected
             p = self.dumps(None, proto)
             self.assertEqual(p, expected)
 
-        oob = list(protocols)[-1] + 1     # a future protocol

[Alexandre Vassalotti, 2008/05/03 07:12:01]

The list() call should be moved to line 13, where the variable `protocols` is
set. 

+        oob = protocols[-1] + 1     # a future protocol
         badpickle = pickle.PROTO + bytes([oob]) + build_none
         try:
             self.loads(badpickle)
         except ValueError as detail:
             self.failUnless(str(detail).startswith(
                                             "unsupported pickle protocol"))
         else:
             self.fail("expected bad protocol number to raise ValueError")
 
     def test_long1(self):
@@ skipping 429 matching lines @@
         for j in range(0, len(p), 20):
             b = bytes(p[j:j+20])
             print("    {0!r}".format(b))
         print(")")
         print()
         print("# Disassembly of DATA{0}".format(i))
         print("DATA{0}_DIS = \"\"\"\\".format(i))
         dis(p)
         print("\"\"\"")
         print()