Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6645)

Issue 6013051: add defer canvas to bench (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by guanqun
Modified:
12 years, 8 months ago
Reviewers:
bsalomon, junov1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

add defer canvas to bench BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M bench/benchmain.cpp View 1 8 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 4
guanqun
I propose to add the option to enable deferred canvas in bench, in this way ...
12 years, 8 months ago (2012-04-13 02:10:31 UTC) #1
junov1
One small comment, otherwise LGTM http://codereview.appspot.com/6013051/diff/1/bench/benchmain.cpp File bench/benchmain.cpp (right): http://codereview.appspot.com/6013051/diff/1/bench/benchmain.cpp#newcode467 bench/benchmain.cpp:467: log_error("missing arg for -forDeferred\n"); ...
12 years, 8 months ago (2012-04-13 14:38:20 UTC) #2
guanqun
On 2012/04/13 14:38:20, junov1 wrote: > One small comment, otherwise LGTM > > http://codereview.appspot.com/6013051/diff/1/bench/benchmain.cpp > ...
12 years, 8 months ago (2012-04-14 12:12:09 UTC) #3
bsalomon
12 years, 8 months ago (2012-04-16 19:11:38 UTC) #4
On 2012/04/14 12:12:09, guanqun wrote:
> On 2012/04/13 14:38:20, junov1 wrote:
> > One small comment, otherwise LGTM
> > 
> > http://codereview.appspot.com/6013051/diff/1/bench/benchmain.cpp
> > File bench/benchmain.cpp (right):
> > 
> > http://codereview.appspot.com/6013051/diff/1/bench/benchmain.cpp#newcode467
> > bench/benchmain.cpp:467: log_error("missing arg for -forDeferred\n");
> > forDeferred -> forceDeferred ?
> 
> Eagle eye! Thanks. I've fixed it in Patch Set 2. If it's OK, please help land
> this CL.

Landed at r3700.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b