Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(655)

Issue 5999047: add circle benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by guanqun
Modified:
12 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

add circle benchmark This is used to measure how fast drawing a circle could be. When the accelerated circle drawing is completed, we can see some improvements from this bench. BUG= TEST=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M bench/PathBench.cpp View 3 chunks +25 lines, -0 lines 2 comments Download

Messages

Total messages: 5
guanqun
This CL is separated from this big CL (draw circle via gpu shader) http://codereview.appspot.com/5696086/ Please ...
12 years, 8 months ago (2012-04-11 01:20:57 UTC) #1
bsalomon
On 2012/04/11 01:20:57, guanqun wrote: > This CL is separated from this big CL (draw ...
12 years, 8 months ago (2012-04-11 13:24:56 UTC) #2
robertphillips
http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp File bench/PathBench.cpp (right): http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp#newcode134 bench/PathBench.cpp:134: virtual void appendName(SkString* name) { Please add SK_OVERRIDE to ...
12 years, 8 months ago (2012-04-11 13:32:46 UTC) #3
bsalomon
On 2012/04/11 13:32:46, robertphillips wrote: > http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp > File bench/PathBench.cpp (right): > > http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp#newcode134 > ...
12 years, 8 months ago (2012-04-11 15:34:55 UTC) #4
guanqun
12 years, 8 months ago (2012-04-12 05:34:30 UTC) #5
http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp
File bench/PathBench.cpp (right):

http://codereview.appspot.com/5999047/diff/1/bench/PathBench.cpp#newcode134
bench/PathBench.cpp:134: virtual void appendName(SkString* name) {
Thanks for your info about SK_OVERRIDE. I'll notice this later.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b