Issue 5992048: Potential fix for xcode 4.1 compiler issue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5992048: Potential fix for xcode 4.1 compiler issue (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by robertphillips

Modified:
12 years, 7 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This change to the xcode settings allows tests to compile under xcode 4.1.

Patch Set 2 : Addressed code review issue #

Patch Set 3 : Addressed code review issue #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/common_conditions.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

epoger

http://codereview.appspot.com/5992048/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): http://codereview.appspot.com/5992048/diff/1/gyp/common_conditions.gypi#newcode125 gyp/common_conditions.gypi:125: 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', can you just put this in the ...

12 years, 7 months ago (2012-04-05 19:02:29 UTC) #2

epoger

LGTM I still get the warnings on Xcode 3.2.6... but indeed it does build successfully.

12 years, 7 months ago (2012-04-05 19:19:11 UTC) #5

committed as r3621

Expand All Messages | Collapse All Messages