Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5089)

Issue 5989067: Warn when ignoring result of SkMatrix::invert. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bungeman
Modified:
12 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Warn when ignoring result of SkMatrix::invert.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M include/core/SkMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPreConfig.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bungeman
Doesn't fix any of the issues yet, but does turn up 10, Two in effects, ...
12 years, 7 months ago (2012-04-09 15:01:14 UTC) #1
reed1
lgtm I love it! Does this need to be conditional for different compilers?
12 years, 7 months ago (2012-04-09 21:40:23 UTC) #2
bungeman
12 years, 7 months ago (2012-04-09 22:34:40 UTC) #3
Committed revision 3637.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b