Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(419)

Issue 5989064: code review 5989064: goprotobuf: Return a clear failure if a non pointer-to-... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by dsymonds
Modified:
13 years, 7 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Return a clear failure if a non pointer-to-struct is passed to Marshal/Unmarshal.

Patch Set 1 #

Patch Set 2 : diff -r 9d6dbca56152 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 9d6dbca56152 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 9d6dbca56152 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M proto/all_test.go View 1 1 chunk +13 lines, -6 lines 0 comments Download
M proto/encode.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M proto/properties.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
13 years, 7 months ago (2012-04-09 06:43:42 UTC) #1
r
LGTM
13 years, 7 months ago (2012-04-09 06:59:48 UTC) #2
dsymonds
13 years, 7 months ago (2012-04-09 07:02:01 UTC) #3
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=d260a6016893 ***

goprotobuf: Return a clear failure if a non pointer-to-struct is passed to
Marshal/Unmarshal.

R=r
CC=golang-dev
http://codereview.appspot.com/5989064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b