Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1985)

Issue 5988071: Blur can now use A8/R8 render targets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Updated blur to use A8/R8 render targets when available. This is only a performance win for large blurs (> ~16)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed code review issues #

Patch Set 3 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -7 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 4 chunks +18 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 5
robertphillips
12 years, 7 months ago (2012-04-10 12:32:21 UTC) #1
bsalomon
How about this model: GrGpu has a boolean table with one entry per GrPixelConfig filled ...
12 years, 7 months ago (2012-04-10 13:35:45 UTC) #2
robertphillips
New version
12 years, 7 months ago (2012-04-10 18:56:02 UTC) #3
bsalomon
On 2012/04/10 18:56:02, robertphillips wrote: > New version LGTM modulo adding comment about RGBA4 always ...
12 years, 7 months ago (2012-04-10 19:15:00 UTC) #4
robertphillips
12 years, 7 months ago (2012-04-10 19:27:04 UTC) #5
committed as r3647
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b