Issue 5988070: misc fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5988070: misc fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by guanqun

Modified:
12 years, 2 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

misc fixes This holds some simple fixes during my process of reading the skia code. It includes: 1. remove incorrect comments. This flag kRectStaysRect_Mask is set in SkMatrix::reset(). 2. typo fixes. 3. remove an extra line in PathTest. BUG= TEST=

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	include/core/SkMatrix.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrPathRendererChain.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PathTest.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, submitted as r3640.

Expand All Messages | Collapse All Messages