Fix GL attach/detach in Mac SampleApp

[robertphillips, 2012-04-03 15:46:27]

LGTM but I did have two questions.

http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm
File src/views/mac/SkNSView.mm (right):

http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm#new...
src/views/mac/SkNSView.mm:228: namespace {
Why the namespace?

http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm#new...
src/views/mac/SkNSView.mm:296: if (fGLContext) {
Shouldn't this be "nil != fGLContext"?

[bsalomon, 2012-04-03 17:55:04]

On 2012/04/03 15:46:27, robertphillips wrote:
> LGTM but I did have two questions.
> 
> http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm
> File src/views/mac/SkNSView.mm (right):
> 
>
http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm#new...
> src/views/mac/SkNSView.mm:228: namespace {
> Why the namespace?

If there was another function in another cpp/mm with the same name we'd get a
collision in the linker. The unnamed namespace gives them different names. Each
unnamed namespace gets a different mangled name.

> 
>
http://codereview.appspot.com/5984043/diff/2001/src/views/mac/SkNSView.mm#new...
> src/views/mac/SkNSView.mm:296: if (fGLContext) {
> Shouldn't this be "nil != fGLContext"?

Yes, will fix when I checkin.

[bsalomon, 2012-04-03 18:10:17]

Closed with r3589

[robertphillips, 2012-04-03 18:10:24]

I guess my question was: should I be doing this everywhere since I don't
remember it from the coding standard? In past places I have worked we made such
functions static members of the related class. This did gunk up the class a bit
but captured the relationship.

[bsalomon, 2012-04-03 18:28:03]

On 2012/04/03 18:10:24, robertphillips wrote:
> I guess my question was: should I be doing this everywhere since I don't
> remember it from the coding standard? In past places I have worked we made
such
> functions static members of the related class. This did gunk up the class a
bit
> but captured the relationship.

In Skia helper functions that don't need to be visible to the clients of the
class (or access to protected/private area of a class) are usually written as
non-members and not declared in the header. There is inconsistency in whether we
declare them as static or put them in an unnamed namespace. Skia uses static a
lot and Mike is partial to it. WebKit and Chrome use unnamed namespaces. Ganesh
initially used static but newer code uses unnamed namespaces and whenever I
touch a static function in Ganesh I convert it to unnamed namespace.