fixing gm build with SkXPSDevice enabled

I tried enabling XPS rendering in gm in my local build and it failed because SkXPSDevice.h includes SkBitSet.h which is no longer visible.

[junov1, 2012-04-03 19:42:22]

PTAL

http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h
File src/utils/SkBitSet.h (left):

http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h#oldcode1
src/utils/SkBitSet.h:1: 
Looks like upload.py does not process 'svn move' correctly. This file is not
being deleted, I am just moving it to the include/utils directory to make it
externally visible.

[bungeman, 2012-04-03 19:51:45]

On 2012/04/03 19:42:22, junov1 wrote:
> PTAL
> 
> http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h
> File src/utils/SkBitSet.h (left):
> 
> http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h#oldcode1
> src/utils/SkBitSet.h:1: 
> Looks like upload.py does not process 'svn move' correctly. This file is not
> being deleted, I am just moving it to the include/utils directory to make it
> externally visible.

Just add 
        '../src/utils', # needed to get SkBitSet.h

to the includes of the xps.gyp (as it is in pdf.gyp). We'd rather not expose
SkBitSet if we don't need to.

[Steve VanDeBogart, 2012-04-03 20:02:42]

On 2012/04/03 19:51:45, bungeman wrote:
> On 2012/04/03 19:42:22, junov1 wrote:
> > PTAL
> > 
> > http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h
> > File src/utils/SkBitSet.h (left):
> > 
> > http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h#oldcode1
> > src/utils/SkBitSet.h:1: 
> > Looks like upload.py does not process 'svn move' correctly. This file is not
> > being deleted, I am just moving it to the include/utils directory to make it
> > externally visible.
> 
> Just add 
>         '../src/utils', # needed to get SkBitSet.h
> 
> to the includes of the xps.gyp (as it is in pdf.gyp). We'd rather not expose
> SkBitSet if we don't need to.

That will fix the problem, but why not move it?  Util is for utility classes so
unless there's a header used internally by util implementation, it seems it
should be in include/util.

[junov1, 2012-04-03 20:06:45]

On 2012/04/03 19:51:45, bungeman wrote:
> On 2012/04/03 19:42:22, junov1 wrote:
> > PTAL
> > 
> > http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h
> > File src/utils/SkBitSet.h (left):
> > 
> > http://codereview.appspot.com/5981054/diff/1/src/utils/SkBitSet.h#oldcode1
> > src/utils/SkBitSet.h:1: 
> > Looks like upload.py does not process 'svn move' correctly. This file is not
> > being deleted, I am just moving it to the include/utils directory to make it
> > externally visible.
> 
> Just add 
>         '../src/utils', # needed to get SkBitSet.h
> 
> to the includes of the xps.gyp (as it is in pdf.gyp). We'd rather not expose
> SkBitSet if we don't need to.

So it was already in the includes, I just had to add it to includes that are
propagated to dependent modules.

[Steve VanDeBogart, 2012-04-03 20:14:31]

LGTM

[bungeman, 2012-04-03 20:49:57]

On 2012/04/03 20:14:31, Steve VanDeBogart wrote:
> LGTM

It is not meant for external use, internal headers for Skia are currently
supposed to be in the src directory. We may change this in the future, but
unless there is a reason to export functions to external users the header needs
to be kept out of 'include'.

[junov1, 2012-07-16 15:54:02]

fixed with r3591