Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(670)

Issue 5981053: Fix blurred shadow rendering for hairline stroked paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by junov1
Modified:
12 years, 1 month ago
Reviewers:
reed, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When drawing shadows of paths we were failing to pass down the information on whether to draw the path stroked or filled. filled was assumed, which failed to render hairline paths correctly. A similar bug also exists in the GPU and XPS devices, which I will fix in separate CLs. I also have a gm test, which I will submit once all the fixes are in. I have a WebKit Layout Test that I will submit once all this rolls in. All this is for this bug: http://code.google.com/p/chromium/issues/detail?id=121251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M include/core/SkDraw.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkDraw.cpp View 4 chunks +14 lines, -8 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkRasterizer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
junov1
PTAL
12 years, 5 months ago (2012-04-03 19:06:45 UTC) #1
junov1
On 2012/04/03 19:06:45, junov1 wrote: > PTAL Adding bsalomon as reviewer (reed is OOO)
12 years, 5 months ago (2012-04-03 21:21:12 UTC) #2
bsalomon
On 2012/04/03 21:21:12, junov1 wrote: > On 2012/04/03 19:06:45, junov1 wrote: > > PTAL > ...
12 years, 5 months ago (2012-04-04 14:17:15 UTC) #3
junov1
> I'm a poor substitute for Mike :) I give a low confidence LGTM (not ...
12 years, 5 months ago (2012-04-04 14:27:44 UTC) #4
junov1
12 years, 1 month ago (2012-07-16 15:55:54 UTC) #5
fixed with r3592
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b