Issue 5979048: Initial split up of Debug Interface into separate files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5979048: Initial split up of Debug Interface into separate files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by robertphillips

Modified:
12 years, 3 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Performed mechanical subdivision of debug interface with following steps: moved each class to its own header added file header & #ifndef/define protector added .cpp that includes header fixed #includes moved code to .cpp if it would force the inclusion of a new header (in favor of predeclarations)

Patch Set 1 #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1087 lines, -782 lines)			Patch
M	gyp/gpu.gyp	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrBufferObj.h	View	1 chunk	+84 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrBufferObj.cpp	View	1 chunk	+9 lines, -0 lines	1 comment	Download
A	src/gpu/gl/debug/GrDebugGL.h	View	1 chunk	+124 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrDebugGL.cpp	View	1 chunk	+196 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFBBindableObj.h	View	1 chunk	+88 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFBBindableObj.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFakeRefObj.h	View	1 chunk	+93 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFakeRefObj.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFrameBufferObj.h	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrFrameBufferObj.cpp	View	1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/gpu/gl/debug/GrGLCreateDebugInterface.cpp	View	2 chunks	+8 lines, -782 lines	0 comments	Download
A	src/gpu/gl/debug/GrProgramObj.h	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrProgramObj.cpp	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrRenderBufferObj.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrRenderBufferObj.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrShaderObj.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrShaderObj.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrTextureObj.h	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrTextureObj.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrTextureUnitObj.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	src/gpu/gl/debug/GrTextureUnitObj.cpp	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

LGTM http://codereview.appspot.com/5979048/diff/1/src/gpu/gl/debug/GrBufferObj.cpp File src/gpu/gl/debug/GrBufferObj.cpp (right): http://codereview.appspot.com/5979048/diff/1/src/gpu/gl/debug/GrBufferObj.cpp#newcode9 src/gpu/gl/debug/GrBufferObj.cpp:9: #include "GrBufferObj.h" Do we need this file? If ...

12 years, 3 months ago (2012-04-05 13:09:35 UTC) #1

committed as r3616

Expand All Messages | Collapse All Messages