Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5308)

Issue 5978055: Minor refactoring to pull GrClipMaskManager into its own files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by robertphillips
Modified:
12 years, 2 months ago
Reviewers:
bsalomon, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Minor refactoring to pull GrClipMaskManager into its own files

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -411 lines) Patch
M gyp/gpu.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/GrClipMaskManager.h View 1 chunk +81 lines, -0 lines 0 comments Download
A src/gpu/GrClipMaskManager.cpp View 1 chunk +359 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +1 line, -60 lines 0 comments Download
M src/gpu/GrGpu.cpp View 4 chunks +0 lines, -351 lines 0 comments Download

Messages

Total messages: 6
robertphillips
12 years, 2 months ago (2012-04-16 17:21:43 UTC) #1
bsalomon
On 2012/04/16 17:21:43, robertphillips wrote: LGTM (will require chrome's skia.gyp to change as well on ...
12 years, 2 months ago (2012-04-16 17:27:37 UTC) #2
robertphillips
How do I make the change to chrome's skia.gyp happen? And why does adding a ...
12 years, 2 months ago (2012-04-16 17:57:12 UTC) #3
TomH
When we do a roll into Chrome (Elliot is the expert here), we update chrome/src/DEPS, ...
12 years, 2 months ago (2012-04-16 17:59:49 UTC) #4
bsalomon
On 2012/04/16 17:57:12, robertphillips wrote: > How do I make the change to chrome's skia.gyp ...
12 years, 2 months ago (2012-04-16 18:01:50 UTC) #5
robertphillips
12 years, 2 months ago (2012-04-16 18:04:02 UTC) #6
committed as r3697
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b