Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8877)

Issue 5976056: Doc: NR 1.2.3 Expl. manual accidentals + cadenzas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by pkx166h
Modified:
11 years, 11 months ago
Reviewers:
Visibility:
Public.

Description

Doc: NR 1.2.3 Expl. manual accidentals + cadenzas Issue 2438 Added notes about using manual accidentals for reminder accidentals when using \cadenzaOn. Add it to note about manual beams. Tidied up some 'third person' references and tightened up sentences along with some 'long' @cindex entries. Added an @ref{}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Patch 2 - Thx Trevor (sorry I took so long) #

Patch Set 3 : Third Patch - more index entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -37 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 4 chunks +56 lines, -37 lines 0 comments Download

Messages

Total messages: 8
Graham Percival
LGTM, please push immediately assuming it passes make doc.
12 years ago (2012-04-01 18:02:48 UTC) #1
Trevor Daniels
A couple of these changes are actually misleading, so I think they at least should ...
12 years ago (2012-04-01 22:09:16 UTC) #2
pkx166h
Thanks Trevor, this one slipped past my radar. http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1415 Documentation/notation/rhythms.itely:1415: @cindex ...
11 years, 11 months ago (2012-04-28 15:15:09 UTC) #3
Trevor Daniels
LGTM, apart from the deleted index entries http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1415 Documentation/notation/rhythms.itely:1415: @cindex beams, ...
11 years, 11 months ago (2012-04-29 09:18:28 UTC) #4
pkx166h
On 2012/04/29 09:18:28, Trevor Daniels wrote: > LGTM, apart from the deleted index entries > ...
11 years, 11 months ago (2012-05-02 06:17:37 UTC) #5
Trevor Daniels
Hi James LGTM Thanks Trevor
11 years, 11 months ago (2012-05-02 08:55:33 UTC) #6
Graham Percival
LGTM
11 years, 11 months ago (2012-05-05 09:28:16 UTC) #7
pkx166h
11 years, 11 months ago (2012-05-09 06:03:05 UTC) #8
committer	James Lowe <pkx166h@gmail.com>	
Wed, 9 May 2012 06:00:15 +0000 (07:00 +0100)
commit	6cc24e4a3246f1daaf79db3bec97a4a4541b5149
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b