Issue 5972065: Augment gm shadow test to cover hairline paths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5972065: Augment gm shadow test to cover hairline paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by junov1

Modified:
12 years, 6 months ago

Reviewers:
bsalomon

CC:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Note: This change will require a rebaseline on all platforms for the gm shadow test.

Patch Set 1 #

Total comments: 1

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	gm/shadows.cpp	View		3 chunks	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Otherwise, LGTM. http://codereview.appspot.com/5972065/diff/1/gm/shadows.cpp File gm/shadows.cpp (right): http://codereview.appspot.com/5972065/diff/1/gm/shadows.cpp#newcode88 gm/shadows.cpp:88: { SK_ColorBLUE, SkFloatToScalar(0.9f)}, Maybe we should make ...

12 years, 9 months ago (2012-04-04 21:25:14 UTC) #2

Fixed with r3612

Expand All Messages | Collapse All Messages