Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(827)

Issue 5972062: Unix SampleApp attach/detach fixup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bsalomon
Modified:
12 years, 7 months ago
Reviewers:
robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -63 lines) Patch
M include/views/SkOSWindow_Unix.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/views/unix/SkOSWindow_Unix.cpp View 1 8 chunks +52 lines, -61 lines 0 comments Download

Messages

Total messages: 3
bsalomon
Make the unix window follow the same semantics as the other platforms: detach destroys the ...
12 years, 7 months ago (2012-04-03 16:00:29 UTC) #1
robertphillips
LGTM
12 years, 7 months ago (2012-04-03 17:33:42 UTC) #2
bsalomon
12 years, 7 months ago (2012-04-06 19:08:12 UTC) #3
checked in r3590
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b