Issue 5969065: Removed ANGLE namespace requirement

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5969065: Removed ANGLE namespace requirement (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by robertphillips

Modified:
12 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This patch manually loads and finds all the GL entry points in the ANGLE library. This allows Skia to use both native gl and ANGLE simultaneously w/o requiring alterations (i.e., a namespace change) to ANGLE.

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -146 lines)			Patch
M	include/gpu/gl/SkANGLEGLContext.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	include/views/SkOSWindow_Win.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp	View	1 chunk	+121 lines, -97 lines	0 comments	Download
M	src/gpu/gl/angle/SkANGLEGLContext.cpp	View	6 chunks	+15 lines, -15 lines	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	6 chunks	+39 lines, -25 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2012/04/02 14:55:37, robertphillips wrote: LGTM, I think we should go with it over the ...

12 years, 7 months ago (2012-04-02 14:58:56 UTC) #2

robertphillips

I agree - this will let us pull the ANGLE source directly.

12 years, 7 months ago (2012-04-02 15:01:01 UTC) #3

committed as r3571

Expand All Messages | Collapse All Messages