http://codereview.appspot.com/5969049/diff/8016/experimental/iOSSampleApp/SkS... File experimental/iOSSampleApp/SkSampleUIView.mm (right): http://codereview.appspot.com/5969049/diff/8016/experimental/iOSSampleApp/SkS... experimental/iOSSampleApp/SkSampleUIView.mm:112: virtual GrRenderTarget* getGrRederTarget() { return fGrRenderTarget; } This should be getGrRenderTarget. Aren't we also supposed to have SK_OVERRIDE here? http://codereview.appspot.com/5969049/diff/8016/include/views/SkOSWindow_Andr... File include/views/SkOSWindow_Android.h (right): http://codereview.appspot.com/5969049/diff/8016/include/views/SkOSWindow_Andr... include/views/SkOSWindow_Android.h:27: bool attach(SkBackEndTypes /* attachType */, int msaaSampleCount) { Will the Android compiler issue an "unused variable" warning for msaaSampleCount? http://codereview.appspot.com/5969049/diff/8016/src/views/ios/SkOSWindow_iOS.mm File src/views/ios/SkOSWindow_iOS.mm (right): http://codereview.appspot.com/5969049/diff/8016/src/views/ios/SkOSWindow_iOS.... src/views/ios/SkOSWindow_iOS.mm:57: bool SkOSWindow::attach(SkBackEndTypes /* attachType */, int msaaSampleCount) { Compiler complaint? http://codereview.appspot.com/5969049/diff/8016/src/views/unix/SkOSWindow_Uni... File src/views/unix/SkOSWindow_Unix.cpp (right): http://codereview.appspot.com/5969049/diff/8016/src/views/unix/SkOSWindow_Uni... src/views/unix/SkOSWindow_Unix.cpp:101: fMSAASampleCount = 0; Not sure why we are setting fMSAASampleCount to zero here?
http://codereview.appspot.com/5969049/diff/8016/experimental/iOSSampleApp/SkS... File experimental/iOSSampleApp/SkSampleUIView.mm (right): http://codereview.appspot.com/5969049/diff/8016/experimental/iOSSampleApp/SkS... experimental/iOSSampleApp/SkSampleUIView.mm:112: virtual GrRenderTarget* getGrRederTarget() { return fGrRenderTarget; } On 2012/04/05 14:33:23, robertphillips wrote: > This should be getGrRenderTarget. Aren't we also supposed to have SK_OVERRIDE > here? Done. http://codereview.appspot.com/5969049/diff/8016/include/views/SkOSWindow_Andr... File include/views/SkOSWindow_Android.h (right): http://codereview.appspot.com/5969049/diff/8016/include/views/SkOSWindow_Andr... include/views/SkOSWindow_Android.h:27: bool attach(SkBackEndTypes /* attachType */, int msaaSampleCount) { On 2012/04/05 14:33:23, robertphillips wrote: > Will the Android compiler issue an "unused variable" warning for > msaaSampleCount? Done. http://codereview.appspot.com/5969049/diff/8016/src/views/ios/SkOSWindow_iOS.mm File src/views/ios/SkOSWindow_iOS.mm (right): http://codereview.appspot.com/5969049/diff/8016/src/views/ios/SkOSWindow_iOS.... src/views/ios/SkOSWindow_iOS.mm:57: bool SkOSWindow::attach(SkBackEndTypes /* attachType */, int msaaSampleCount) { On 2012/04/05 14:33:23, robertphillips wrote: > Compiler complaint? Done. http://codereview.appspot.com/5969049/diff/8016/src/views/unix/SkOSWindow_Uni... File src/views/unix/SkOSWindow_Unix.cpp (right): http://codereview.appspot.com/5969049/diff/8016/src/views/unix/SkOSWindow_Uni... src/views/unix/SkOSWindow_Unix.cpp:101: fMSAASampleCount = 0; On 2012/04/05 14:33:23, robertphillips wrote: > Not sure why we are setting fMSAASampleCount to zero here? Either requestedMSAASampleCount was 0 or we tried to choose a "visual" with the requestedMSAASampleCount and failed. The line above we chose a visual without MSAA.
Other than lingering issue in SkSampleUIView.mm - LGTM.
Closed with 3627
