Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3341)

Issue 5969044: Added run-time switching between OpenGL & ANGLE in SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by robertphillips
Modified:
12 years, 3 months ago
Reviewers:
DerekS, bsalomon, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This patch allows SampleApp to switch to ANGLE via the usual left-arrow mechanism. There is still an issue where ANGLE doesn't clean up correctly (so one cannot switch back to OpenGL from ANGLE).

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed code review issues #

Patch Set 3 : Now with cross platform support #

Patch Set 4 : Added Android #

Patch Set 5 : Now with iOS #

Patch Set 6 : code updated to match latest in svn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+963 lines, -816 lines) Patch
M include/views/SkOSWindow_Android.h View 1 2 3 4 5 1 chunk +9 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_Mac.h View 1 2 3 4 5 1 chunk +9 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_Unix.h View 1 2 3 4 5 1 chunk +9 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 2 3 4 5 2 chunks +25 lines, -13 lines 0 comments Download
M include/views/SkOSWindow_iOS.h View 1 2 3 4 5 1 chunk +9 lines, -3 lines 0 comments Download
M samplecode/SampleApp.h View 1 2 3 4 5 5 chunks +9 lines, -7 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 15 chunks +163 lines, -156 lines 0 comments Download
M src/views/mac/SkOSWindow_Mac.cpp View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/views/unix/SkOSWindow_Unix.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 2 3 4 5 1 chunk +724 lines, -622 lines 0 comments Download

Messages

Total messages: 10
robertphillips
12 years, 3 months ago (2012-03-30 12:04:00 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/5969044/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/5969044/diff/1/samplecode/SampleApp.cpp#newcode1634 samplecode/SampleApp.cpp:1634: this->setDeviceType(kNullGPU_DeviceType); Did you test that hitting \ still ...
12 years, 3 months ago (2012-03-30 13:42:18 UTC) #2
TomH
Woot!
12 years, 3 months ago (2012-03-30 13:50:05 UTC) #3
robertphillips
http://codereview.appspot.com/5969044/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/5969044/diff/1/samplecode/SampleApp.cpp#newcode1634 samplecode/SampleApp.cpp:1634: this->setDeviceType(kNullGPU_DeviceType); Yes - I also ensured that toggling away ...
12 years, 3 months ago (2012-03-30 14:46:14 UTC) #4
robertphillips
committed as r3555
12 years, 3 months ago (2012-03-30 14:48:31 UTC) #5
robertphillips
Still need to talk to Derek about Android.
12 years, 3 months ago (2012-03-30 15:59:06 UTC) #6
DerekS
On 2012/03/30 15:59:06, robertphillips wrote: > Still need to talk to Derek about Android. lgtm ...
12 years, 3 months ago (2012-04-02 16:41:29 UTC) #7
bsalomon
On 2012/04/02 16:41:29, djsollen wrote: > On 2012/03/30 15:59:06, robertphillips wrote: > > Still need ...
12 years, 3 months ago (2012-04-02 16:59:54 UTC) #8
bsalomon
On 2012/04/02 16:59:54, bsalomon wrote: > On 2012/04/02 16:41:29, djsollen wrote: > > On 2012/03/30 ...
12 years, 3 months ago (2012-04-02 20:12:23 UTC) #9
robertphillips
12 years, 3 months ago (2012-04-02 20:59:50 UTC) #10
committed as r3578 and r3579
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b