Issue 5967047: libjpeg/cmykjpeg .gyps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5967047: libjpeg/cmykjpeg .gyps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by robertphillips

Modified:
12 years, 9 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

These .gyp files get the libjpeg/cmykjpeg test working on Windows and Linux. The 3 issues with them are: couldn't get non-direct paths to work on Windows had to add '-ljpeg' for Unix Altering the include_dirs variable in libjpeg.gyp got Windows compiling but broke the Unix version. In this case I believe the Unix build is getting confused between the installed libjpeg and the third_party one.

Patch Set 1 #

Patch Set 2 : Incorporated lessons learned from ANGLE .gyp cleanup #

Patch Set 3 : Minor changes to get Mac & Android compiling #

Patch Set 4 : Fixed spaces in .gyp #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -12 lines)			Patch
M	gyp/gmslides.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/images.gyp	View	1 2 3	6 chunks	+5 lines, -11 lines	0 comments	Download
M	gyp/libjpeg.gyp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

LGTM P.S. I never received an email about this code review... it may be that ...

12 years, 9 months ago (2012-04-03 14:31:23 UTC) #2

committed as r3611

Expand All Messages | Collapse All Messages