Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19064)

Issue 5966045: code review 5966045: go.crypto: add exp/terminal as code.google.com/p/go.cry... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dsymonds
Modified:
12 years ago
Reviewers:
CC:
golang-dev, dfc, r
Visibility:
Public.

Description

go.crypto: add exp/terminal as code.google.com/p/go.crypto/ssh/terminal. This removes the sole "exp/foo" import in the Go subrepos. A separate CL will remove exp/terminal from the standard Go repository.

Patch Set 1 #

Patch Set 2 : diff -r fbae31f0f8f0 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r fbae31f0f8f0 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r fbae31f0f8f0 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -2 lines) Patch
M ssh/example_test.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssh/session_test.go View 1 1 chunk +2 lines, -1 line 0 comments Download
A ssh/terminal/terminal.go View 1 1 chunk +520 lines, -0 lines 0 comments Download
A ssh/terminal/terminal_test.go View 1 1 chunk +110 lines, -0 lines 0 comments Download
A ssh/terminal/util.go View 1 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
12 years ago (2012-03-30 04:18:28 UTC) #1
dfc
LGTM. Not ideal but this will do until there is a broader need for terminal ...
12 years ago (2012-03-30 04:21:35 UTC) #2
r
LGTM
12 years ago (2012-03-30 04:25:58 UTC) #3
dsymonds
12 years ago (2012-03-30 04:27:06 UTC) #4
*** Submitted as
http://code.google.com/p/go/source/detail?r=33d6505b6597&repo=crypto ***

go.crypto: add exp/terminal as code.google.com/p/go.crypto/ssh/terminal.

This removes the sole "exp/foo" import in the Go subrepos.
A separate CL will remove exp/terminal from the standard Go repository.

R=golang-dev, dave, r
CC=golang-dev
http://codereview.appspot.com/5966045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b