Issue 5960044: code review 5960044: go.crypto/ssh: improve error message when no authentica...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5960044: code review 5960044: go.crypto/ssh: improve error message when no authentica... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dfc

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

go.crypto/ssh: improve error message when no authentication methods remain

Patch Set 1 #

Patch Set 2 : diff -r 91ccd0bd392e https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 33d6505b6597 https://code.google.com/p/go.crypto #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	ssh/client_auth.go	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dfc

The old error message was a rather confusing way of saying either 'you got your ...

12 years ago (2012-03-29 10:06:11 UTC) #1

dfc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto

12 years ago (2012-04-01 07:14:35 UTC) #2

agl1

12 years ago (2012-04-01 14:50:25 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=45667c991e8e&repo=crypto ***

go.crypto/ssh: improve error message when no authentication methods remain

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5960044

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages