Issue 5955047: Removing extraneous files from the jarjar'ed Apache Commons Codec Library

Issue 5955047: Removing extraneous files from the jarjar'ed Apache Commons Codec Library (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rmistry

Modified:
12 years, 1 month ago

Reviewers:
yanivi

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 3 : Review comments #

Patch Set 4 : Minor fix #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	google-http-client/pom.xml	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
	M	pom.xml	View	1 2	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

yanivi

While you are doing this, please do one more optimization: Add this: <addMavenDescriptor>false</addMavenDescriptor> under: <plugin> ...

12 years, 1 month ago (2012-03-29 14:43:53 UTC) #2

yanivi

http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml File google-http-client/pom.xml (right): http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml#newcode76 google-http-client/pom.xml:76: <exclude name="META-INF/**/*"/> a little too aggressive: we do want ...

12 years, 1 month ago (2012-03-29 14:44:04 UTC) #3

yanivi

http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml File google-http-client/pom.xml (right): http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml#newcode72 google-http-client/pom.xml:72: <jar destfile="target/scrubbed.jar"> add this: filesetmanifest="merge" which will preserve the ...

12 years, 1 month ago (2012-03-29 15:55:41 UTC) #4

rmistry

http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml File google-http-client/pom.xml (right): http://codereview.appspot.com/5955047/diff/2001/google-http-client/pom.xml#newcode72 google-http-client/pom.xml:72: <jar destfile="target/scrubbed.jar"> On 2012/03/29 15:55:41, yanivi wrote: > add ...

12 years, 1 month ago (2012-03-29 16:24:49 UTC) #5

yanivi

LGTM http://codereview.appspot.com/5955047/diff/4006/pom.xml File pom.xml (right): http://codereview.appspot.com/5955047/diff/4006/pom.xml#newcode197 pom.xml:197: <addMavenDescriptor>false</addMavenDescriptor> [aside] we should ideally do the same ...

12 years, 1 month ago (2012-03-29 16:28:35 UTC) #6

rmistry

12 years, 1 month ago (2012-03-29 18:05:03 UTC) #7

http://codereview.appspot.com/5955047/diff/4006/pom.xml
File pom.xml (right):

http://codereview.appspot.com/5955047/diff/4006/pom.xml#newcode197
pom.xml:197: <addMavenDescriptor>false</addMavenDescriptor>
On 2012/03/29 16:28:36, yanivi wrote:
> [aside] we should ideally do the same for oauth & api but it can wait for 1.9
if
> you want

Done:
http://code.google.com/p/google-oauth-java-client/source/detail?r=1d4c9a8960d...
http://code.google.com/p/google-api-java-client/source/detail?r=983d791340553...

Expand All Messages | Collapse All Messages