Consolidate PixelRef flattables with the standard impl

Consolidate PixelRef flattables with the standard impl

gcl created a new issue that can be found at the link below so I'm closing out this issue.

http://codereview.appspot.com/5941043/

[reed1, 2012-03-28 19:46:59]

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (left):

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h#oldcod...
include/core/SkPixelRef.h:147: typedef SkPixelRef*
(*Factory)(SkFlattenableReadBuffer&);
are these two additions needed, since we now inherit from SkFlattenable?

http://codereview.appspot.com/5939053/diff/1/src/ports/SkGlobalInitialization...
File src/ports/SkGlobalInitialization_default.cpp (right):

http://codereview.appspot.com/5939053/diff/1/src/ports/SkGlobalInitialization...
src/ports/SkGlobalInitialization_default.cpp:81:
SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkMallocPixelRef)
I think only android uses ashmem...

[caryclark1, 2012-03-28 19:49:01]

A comment about why formerly const functions became not const would be good.

http://codereview.appspot.com/5939053/diff/1/include/images/SkFlipPixelRef.h
File include/images/SkFlipPixelRef.h (left):

http://codereview.appspot.com/5939053/diff/1/include/images/SkFlipPixelRef.h#...
include/images/SkFlipPixelRef.h:68: private:
second 'private' no longer needed?

http://codereview.appspot.com/5939053/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

http://codereview.appspot.com/5939053/diff/1/src/core/SkBitmap.cpp#newcode1470
src/core/SkBitmap.cpp:1470: SkPixelRef* pr =
(SkPixelRef*)buffer.readFlattenable();
what kind of cast is this? dynamic_cast?

[DerekS, 2012-03-28 20:27:19]

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (left):

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h#oldcod...
include/core/SkPixelRef.h:147: typedef SkPixelRef*
(*Factory)(SkFlattenableReadBuffer&);
On 2012/03/28 19:46:59, reed1 wrote:
> are these two additions needed, since we now inherit from SkFlattenable?

getFactory() is not, but the other is as the cpp file has an implementation of
this.

http://codereview.appspot.com/5939053/diff/1/include/images/SkFlipPixelRef.h
File include/images/SkFlipPixelRef.h (left):

http://codereview.appspot.com/5939053/diff/1/include/images/SkFlipPixelRef.h#...
include/images/SkFlipPixelRef.h:68: private:
On 2012/03/28 19:49:01, caryclark1 wrote:
> second 'private' no longer needed?

Done.

http://codereview.appspot.com/5939053/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

http://codereview.appspot.com/5939053/diff/1/src/core/SkBitmap.cpp#newcode1470
src/core/SkBitmap.cpp:1470: SkPixelRef* pr =
(SkPixelRef*)buffer.readFlattenable();
On 2012/03/28 19:49:01, caryclark1 wrote:
> what kind of cast is this? dynamic_cast? 

Done. It is a static cast.

http://codereview.appspot.com/5939053/diff/1/src/ports/SkGlobalInitialization...
File src/ports/SkGlobalInitialization_default.cpp (right):

http://codereview.appspot.com/5939053/diff/1/src/ports/SkGlobalInitialization...
src/ports/SkGlobalInitialization_default.cpp:81:
SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkMallocPixelRef)
On 2012/03/28 19:46:59, reed1 wrote:
> I think only android uses ashmem...

Done.

[reed1, 2012-03-28 20:50:49]

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (left):

http://codereview.appspot.com/5939053/diff/1/include/core/SkPixelRef.h#oldcod...
include/core/SkPixelRef.h:147: typedef SkPixelRef*
(*Factory)(SkFlattenableReadBuffer&);
So...

1. can we remove the getFactory?
2. should we say SK_OVERRIDE on flatten?

On 2012/03/28 20:27:19, djsollen wrote:
> On 2012/03/28 19:46:59, reed1 wrote:
> > are these two additions needed, since we now inherit from SkFlattenable?
> 
> getFactory() is not, but the other is as the cpp file has an implementation of
> this.