Issue 5939048: [ASan] interceptors for atoi/atol/atoll

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5939048: [ASan] interceptors for atoi/atol/atoll (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by samsonov

Modified:
12 years, 10 months ago

Reviewers:
kcc1, timurrrr_at_google_com

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Patch Set 1 : [ASan] interceptors for atoi/atol/atoll #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -17 lines)			Patch
	M	asan_interceptors.cc	View		5 chunks	+61 lines, -15 lines	0 comments	Download
	M	tests/asan_test.cc	View		2 chunks	+46 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kcc1

12 years, 10 months ago (2012-03-28 18:10:32 UTC) #2

Looks good, thanks!

On Wed, Mar 28, 2012 at 3:39 AM, <samsonov@google.com> wrote:

> Reviewers: kcc1, timurrrr_at_google_com,
>
>
>
> Please review this at
http://codereview.appspot.com/**5939048/<http://codereview.appspot.com/5939048/>
>
> Affected files:
>  M     asan_interceptors.cc
>  M     tests/asan_test.cc
>
>
>

Expand All Messages | Collapse All Messages