Issue 5938054: moved Debug GL interface to src/gpu/gl/debug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5938054: moved Debug GL interface to src/gpu/gl/debug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by robertphillips

Modified:
12 years, 3 months ago

Reviewers:
epoger, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Moved Debug GL interface to src/gpu/gl/debug. This is in preparation for splitting up GrGLCreateDebugInterface.cpp. It is currently 1737 LOC.

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1751 lines)			Patch
M	gyp/gpu.gyp	View	3 chunks	+4 lines, -2 lines	0 comments	Download
D	src/gpu/gl/GrGLCreateDebugInterface.cpp	View	1 chunk	+0 lines, -1736 lines	0 comments	Download
D	src/gpu/gl/SkDebugGLContext.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 6

bsalomon

On 2012/03/28 17:48:45, robertphillips wrote: LGTM (I presume the A's are also in the svn ...

12 years, 3 months ago (2012-03-28 18:02:59 UTC) #2

robertphillips

They are - I wonder why they didn't show up in the code review!

12 years, 3 months ago (2012-03-28 18:05:06 UTC) #3

bsalomon

On 2012/03/28 18:05:06, robertphillips wrote: > They are - I wonder why they didn't show ...

12 years, 3 months ago (2012-03-28 18:08:36 UTC) #4

committed as r3526