Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6861)

Issue 5935043: [Issue 79] JacksonFactory.createJsonParser should throw NullPointerException on null input (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by yanivi
Modified:
12 years ago
Reviewers:
rmistry
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 2

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1256 lines) Patch
M google-http-client/src/main/java/com/google/api/client/json/JsonFactory.java View 3 chunks +3 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/jackson/JacksonFactory.java View 2 chunks +4 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpRequest.java View 3 chunks +31 lines, -1 line 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java View 3 chunks +7 lines, -4 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/json/AbstractJsonFactoryTest.java View 2 chunks +29 lines, -0 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/testing/json/AbstractJsonGeneratorTest.java View 1 chunk +0 lines, -81 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/testing/json/AbstractJsonParserTest.java View 1 chunk +0 lines, -1021 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/json/gson/GsonGeneratorTest.java View 1 chunk +0 lines, -37 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/json/gson/GsonParserTest.java View 1 chunk +0 lines, -37 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/json/jackson/JacksonGeneratorTest.java View 1 chunk +0 lines, -37 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/json/jackson/JacksonParserTest.java View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 3
yanivi
12 years ago (2012-03-27 17:01:23 UTC) #1
rmistry
LGTM http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java File google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java (right): http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java#newcode99 google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:99: /** Serializes the given JSON value object or ...
12 years ago (2012-03-28 12:20:32 UTC) #2
yanivi
12 years ago (2012-03-28 13:10:34 UTC) #3
Submitting now...

http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java
(right):

http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:99:
/** Serializes the given JSON value object or {@code null} for no serialization.
*/
On 2012/03/28 12:20:33, rmistry wrote:
> "{@code null} for no serialization" makes it sound like the method returns a
> null. How about something like "Does no serialization if {@code value} is
{@code
> null}"

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b