LGTM http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java File google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java (right): http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java#newcode99 google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:99: /** Serializes the given JSON value object or ...
Submitting now...
http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java
(right):
http://codereview.appspot.com/5935043/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:99:
/** Serializes the given JSON value object or {@code null} for no serialization.
*/
On 2012/03/28 12:20:33, rmistry wrote:
> "{@code null} for no serialization" makes it sound like the method returns a
> null. How about something like "Does no serialization if {@code value} is
{@code
> null}"
Done.
Issue 5935043: [Issue 79] JacksonFactory.createJsonParser should throw NullPointerException on null input
(Closed)
Created 12 years ago by yanivi
Modified 12 years ago
Reviewers: rmistry
Base URL: https://google-http-java-client.googlecode.com/hg/
Comments: 2