Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 5934044: Correct dependencies in gyp files.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by bungeman
Modified:
12 years, 8 months ago
Reviewers:
epoger
CC:
DerekS
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Correct dependencies in gyp files.

Patch Set 1 #

Patch Set 2 : Clean up. #

Patch Set 3 : After some tree cleaning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -44 lines) Patch
M gyp/animator.gyp View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M gyp/core.gyp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M gyp/effects.gyp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M gyp/experimental.gyp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M gyp/gpu.gyp View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M gyp/images.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/opts.gyp View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M gyp/ports.gyp View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M gyp/utils.gyp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M gyp/views.gyp View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M gyp/views_animated.gyp View 1 2 1 chunk +8 lines, -9 lines 0 comments Download
M gyp/xml.gyp View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6
bungeman
I wanted to put this out there so it could be seen, but we're going ...
12 years, 8 months ago (2012-03-28 17:23:57 UTC) #1
epoger
LGTM
12 years, 8 months ago (2012-03-28 18:36:20 UTC) #2
bungeman
Committed revision 3538.
12 years, 8 months ago (2012-03-29 14:29:34 UTC) #3
bungeman
On 2012/03/29 14:29:34, bungeman wrote: > Committed revision 3538. Reverted 3538. Works fine on Linux, ...
12 years, 8 months ago (2012-03-29 14:59:52 UTC) #4
epoger
12 years, 8 months ago (2012-03-29 15:02:13 UTC) #5
epoger
12 years, 8 months ago (2012-03-29 15:03:52 UTC) #6
On 2012/03/29 14:59:52, bungeman wrote:
> On 2012/03/29 14:29:34, bungeman wrote:
> > Committed revision 3538.
> 
> Reverted 3538.
> 
> Works fine on Linux, Windows, and Mac. Android has issues because of
> SkGlobalInitialization*. The issue is that this makes ports depend on effects
> (and possibly others). The underlying issue is that SkGlobalInitialization is
> not really a port (which is a platform concept) but a user config.

Thanks for the quick revert, Ben.  Although it probably would have been OK for
the Android build to be broken for an hour...

You should be able to follow the steps at
http://code.google.com/p/skia/wiki/GettingStartedOnAndroid to reproduce the
build error; let Derek or me know if you'd like any help with that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b