code review 5933055: nix: sync with plan 9

nix: sync with plan 9

[0intro, 2012-03-28 12:39:59]

Hello nixiedev@gmail.com (cc: nix-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/nix-os/

[nemo_lsub.org, 2012-03-28 13:17:20]

LGTM

BTW, could we get one of these per week?
I think we are getting them daily or so.

On Mar 28, 2012, at 2:39 PM, 0intro@gmail.com wrote:

> Reviewers: Nixie,
> 
> Message:
> Hello nixiedev@gmail.com (cc: nix-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/nix-os/
> 
> 
> Description:
> nix: sync with plan 9
> 
> Please review this at http://codereview.appspot.com/5933055/
> 
> Affected files:
>  M arm/include/u.h
>  M rc/bin/diffy
>  M sys/man/3/cons
>  M sys/src/cmd/5l/obj.c
>  M sys/src/libc/arm/getcallerpc.s
>  M sys/src/libc/arm/main9p.s
>  M sys/src/libc/arm/memmove.s
>  M sys/src/libc/arm/strchr.s
>  M sys/src/libc/arm/strcmp.s
>  M sys/src/libc/arm/strcpy.s
>  M sys/src/libc/arm/tas.s
>  M sys/src/libc/arm/vlop.s
>  M sys/src/libmach/5db.c
> 

[quanstro, 2012-03-28 14:09:44]

lgtm

http://codereview.appspot.com/5933055/diff/5001/arm/include/u.h
File arm/include/u.h (right):

http://codereview.appspot.com/5933055/diff/5001/arm/include/u.h#newcode25
arm/include/u.h:25: #define	FPINEX	(1<<12)			/* trap enables for exceptions */
it seems that a change in a file makes it many times
more likely that another change will come in a week.
perhaps we should employ an "interrupt coalescing delay" :-)

http://codereview.appspot.com/5933055/diff/5001/rc/bin/diffy
File rc/bin/diffy (right):

http://codereview.appspot.com/5933055/diff/5001/rc/bin/diffy#newcode14
rc/bin/diffy:14: * = (.)
should read "* = .".  the parens are misleading.

[0intro, 2012-03-28 14:53:18]

> BTW, could we get one of these per week?
> I think we are getting them daily or so.

As long as no one submit it, the changes will
automatically coalesce in this CL each day.

But we can restrict it to once per week if you wish.
Monday at 14:00 CET seems good to me.

What do you think?

-- 
David du Colombier

[nemo_lsub.org, 2012-03-28 15:02:14]

that's fine, yes.

On Mar 28, 2012, at 4:53 PM, David du Colombier wrote:

>> BTW, could we get one of these per week?
>> I think we are getting them daily or so.
> 
> As long as no one submit it, the changes will
> automatically coalesce in this CL each day.
> 
> But we can restrict it to once per week if you wish.
> Monday at 14:00 CET seems good to me.
> 
> What do you think?
> 
> -- 
> David du Colombier

[0intro, 2012-04-02 12:04:25]

Hello nixiedev@gmail.com, nemo@lsub.org, quanstro@quanstro.net (cc:
nix-dev@googlegroups.com),

Please take another look.

[0intro, 2012-04-03 07:31:24]

*** Abandoned ***