Issue 5924049: fix redundant typedef

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5924049: fix redundant typedef (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by guanqun

Modified:
12 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix redundant typedef This typedef with enum is redundant, besides here's the warning from compiler. CXX(target) Release/obj.target/gr/src/gpu/gl/GrGLCreateDebugInterface.o ../src/gpu/gl/GrGLCreateDebugInterface.cpp:567:5: warning: ‘typedef’ was ignored in this declaration [enabled by default] So I'd suggest to remove this. BUG= TEST=

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/gl/GrGLCreateDebugInterface.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

guanqun

please review, if it's ok, please help land this fix. Thanks!

12 years, 6 months ago (2012-03-27 07:22:27 UTC) #1

robertphillips

12 years, 6 months ago (2012-03-28 12:51:40 UTC) #3

On 2012/03/28 12:50:43, robertphillips wrote:
> LGTM

Delivered as revision 3513

Expand All Messages | Collapse All Messages