Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1467)

Issue 59170045: Issue 1257:Use datastore to store log info.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by QiaoLiang89
Modified:
10 years, 9 months ago
Reviewers:
damith
Visibility:
Public.

Description

Issue 1257:Use datastore to store log info.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Issue 1257:Use datastore to store log info. #

Messages

Total messages: 3
damith
https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storage/entity/LogEntry.java File src/main/java/teammates/storage/entity/LogEntry.java (right): https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storage/entity/LogEntry.java#newcode61 src/main/java/teammates/storage/entity/LogEntry.java:61: private long createdAt; Why not use Date? That's the ...
10 years, 9 months ago (2014-02-01 11:16:26 UTC) #1
QiaoLiang89
https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storage/entity/LogEntry.java File src/main/java/teammates/storage/entity/LogEntry.java (right): https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storage/entity/LogEntry.java#newcode61 src/main/java/teammates/storage/entity/LogEntry.java:61: private long createdAt; I am trying to keep it ...
10 years, 9 months ago (2014-02-01 13:08:13 UTC) #2
damith
10 years, 9 months ago (2014-02-01 15:11:33 UTC) #3
https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storag...
File src/main/java/teammates/storage/entity/LogEntry.java (right):

https://codereview.appspot.com/59170045/diff/1/src/main/java/teammates/storag...
src/main/java/teammates/storage/entity/LogEntry.java:61: private long createdAt;
I see.
It's fine if it is easy to convert that back to a time.
Otherwise go for the Date type which may not need any conversion.

On 2014/02/01 13:08:13, QiaoLiang89 wrote:
> I am trying to keep it consistent with the current loging approach where it
was
> recorded like this in ActivityLogEntry
> "
> private long time;
> "
> and 
> "
> time = System.currentTimeMillis();
> "
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b