Issue 5909048: Reduce amount of consing (mostly replace reverse with reverse! where appropriate)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5909048: Reduce amount of consing (mostly replace reverse with reverse! where appropriate) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dak

Modified:
12 years ago

Reviewers:

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Reduce amount of consing (mostly replace reverse with reverse! where appropriate) There is one slightly non-trivial change in that it changes evaluation order in lily/page-breaking.cc @@ -552,7 +552,7 @@ Page_breaking::draw_page (SCM systems, SCM configuration, in I don't expect it to be problematic, but it might be worth checking more thoroughly than the rest.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	lily/articulations.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/key-engraver.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/line-spanner.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lily/page-breaking.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	lily/page-layout-problem.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/paper-book.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	lily/system.cc	View	1 chunk	+1 line, -1 line	0 comments	Download