Issue 5905069: Make GrDrawState ref counted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5905069: Make GrDrawState ref counted (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : fix size of the memset #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -23 lines)			Patch
	M	src/gpu/GrDrawState.h	View	1	8 chunks	+45 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

By itself this is of no value. The motivation is to make the GrDrawState of ...

12 years, 7 months ago (2012-03-26 19:59:57 UTC) #1

TomH

On 2012/03/26 19:59:57, bsalomon wrote: > By itself this is of no value. By itself ...

12 years, 7 months ago (2012-03-26 20:26:02 UTC) #2

bsalomon

12 years, 7 months ago (2012-03-26 20:34:09 UTC) #3

On 2012/03/26 20:26:02, TomH wrote:
> On 2012/03/26 19:59:57, bsalomon wrote:
> > By itself this is of no value.
> 
> By itself this is of negative value, since we lose POD and gain lots of ugly.
> However, I'm an optimist, and have faith in you, Brian, so LGTM. :)

Ha, thanks. How kind! Checked in at r3498.

Expand All Messages | Collapse All Messages