Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 5903043: Extended debug GL interface to include textures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by robertphillips
Modified:
12 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Extended debug GL interface to include textures. This delivery also includes some cleanup of the debug interface's framework (e.g., added a factory to unify object creation, merged the find methods to reduce redundancy, added a shared base class between render buffer and texture objects) Made minor change to GrGpuGL.cpp to unbind a texture from the current texture unit before attaching it to the frame buffer.

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -185 lines) Patch
M src/gpu/gl/GrGLCreateDebugInterface.cpp View 1 36 chunks +459 lines, -185 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 8 months ago (2012-03-23 21:08:35 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/5903043/diff/1/src/gpu/gl/GrGLCreateDebugInterface.cpp File src/gpu/gl/GrGLCreateDebugInterface.cpp (right): http://codereview.appspot.com/5903043/diff/1/src/gpu/gl/GrGLCreateDebugInterface.cpp#newcode33 src/gpu/gl/GrGLCreateDebugInterface.cpp:33: public: \ If your defining macros only used ...
12 years, 8 months ago (2012-03-26 14:06:44 UTC) #2
robertphillips
12 years, 8 months ago (2012-03-26 17:59:41 UTC) #3
committed as r3495

http://codereview.appspot.com/5903043/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
File src/gpu/gl/GrGLCreateDebugInterface.cpp (right):

http://codereview.appspot.com/5903043/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
src/gpu/gl/GrGLCreateDebugInterface.cpp:33: public:                             
                   \
On 2012/03/26 14:06:44, bsalomon wrote:
> If your defining macros only used within this cpp its ok (but not required) to
> drop the GR_ prefix.
> 
> minor nit: it might be nice to line up the \s

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b