Issue 5889: * Use scm_to_int64/from_int64 for Rational/SCM conversions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5889: * Use scm_to_int64/from_int64 for Rational/SCM conversions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by Neil Puttock

Modified:
15 years, 9 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Also use I64 in moment.cc, moment-scheme.cc and duration-scheme.cc.

Patch Set 1 #

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	lily/duration-scheme.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/moment.hh	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/lily-guile.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	lily/moment.cc	View	2 chunks	+6 lines, -6 lines	1 comment	Download
M	lily/moment-scheme.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

hanwenn

16 years, 7 months ago (2008-09-21 18:43:43 UTC) #1

LGTM - this is what I meant.

http://codereview.appspot.com/5889/diff/1/6
File lily/moment.cc (right):

http://codereview.appspot.com/5889/diff/1/6#newcode134
Line 134: {
If you want to be paranoid, you could check that the most significant bit is 1
here.

Expand All Messages | Collapse All Messages