Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 5889: * Use scm_to_int64/from_int64 for Rational/SCM conversions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by Neil Puttock
Modified:
14 years, 8 months ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Also use I64 in moment.cc, moment-scheme.cc and duration-scheme.cc.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M lily/duration-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/moment.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/lily-guile.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M lily/moment.cc View 2 chunks +6 lines, -6 lines 1 comment Download
M lily/moment-scheme.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1
hanwenn
15 years, 6 months ago (2008-09-21 18:43:43 UTC) #1
LGTM - this is what I meant.

http://codereview.appspot.com/5889/diff/1/6
File lily/moment.cc (right):

http://codereview.appspot.com/5889/diff/1/6#newcode134
Line 134: {
If you want to be paranoid, you could check that the most significant bit is 1
here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b