Issue 5885057: when paint has patheffect, it should fallback to path render

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5885057: when paint has patheffect, it should fallback to path render (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by guanqun

Modified:
12 years, 8 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

when paint has patheffect for drawRect, it should fallback to path render BUG= TEST=

Patch Set 1 #

Patch Set 2 : set aa to true #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	gm/patheffects.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

guanqun

Using path effect will fill style seems weird at first glance. That said, this is ...

12 years, 8 months ago (2012-03-23 05:21:22 UTC) #1

bsalomon

On 2012/03/23 05:21:22, guanqun wrote: > Using path effect will fill style seems weird at ...

12 years, 8 months ago (2012-03-26 14:29:41 UTC) #2

bsalomon

12 years, 8 months ago (2012-03-26 15:25:24 UTC) #3

On 2012/03/26 14:29:41, bsalomon wrote:
> On 2012/03/23 05:21:22, guanqun wrote:
> > Using path effect will fill style seems weird at first glance. That said,
this
> > is a bug which should be fixed. Otherwise, it draws solid rectangles.
> > 
> > Please review. Thanks!
> 
> Nice catch. LGTM. I'll commit it.

Committed at r3487

Expand All Messages | Collapse All Messages