Issue 5885043: code review 5885043: cmd/go: fix unchecked error in get.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5885043: code review 5885043: cmd/go: fix unchecked error in get.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by cookieo9

Modified:
12 years, 11 months ago

Reviewers:
golang-dev

Visibility:
Public.

Description

cmd/go: fix unchecked error in get.go If you call go get -u on a package not tracked by a VCS you get a panic, and the command dies. This is caused by an error value not being checked during the execution of downloadPackage().

Patch Set 1 #

Patch Set 2 : diff -r 6b52d2564c9c https://code.google.com/p/go #

Patch Set 3 : diff -r 6b52d2564c9c https://code.google.com/p/go #

Created: 12 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/cmd/go/get.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cookieo9

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 12 months ago (2012-03-22 03:09:17 UTC) #1

cookieo9

12 years, 11 months ago (2012-03-26 02:23:57 UTC) #3

On 2012/03/26 02:23:10, cookieo9 wrote:
> *** Abandoned ***

Made obsolete by http://codereview.appspot.com/5874055 submitted as
http://code.google.com/p/go/source/detail?r=f707188b1ec3

Expand All Messages | Collapse All Messages