On 2012/03/23 13:04:19, Pavel Roskin wrote:
> This is also the first use of a scheme engraver in input/regression.
Apart from scheme-engraver.ly, scheme-engraver-instance.ly, and
scheme-text-spanner.ly.
OK, I'll use make-engraver in the next revision. I guess I'll need to strip all
Lilypond 2.14 compatibility stuff if this snippet is to be a part of the
Lilypond documentation. I missed scheme engravers because I was looking for
"\consists #" on one line, my bad.
On 2012/03/23 21:46:41, Pavel Roskin wrote:
> OK, I'll use make-engraver in the next revision. I guess I'll need to strip
all
> Lilypond 2.14 compatibility stuff if this snippet is to be a part of the
> Lilypond documentation.
In LilyPond itself, it makes sense to document the latest version. If people
read 2.16 documentation, they can't expect to see stuff that is guaranteed to
work under 2.14.
It is not uncommon for some new features to be only discernible from regtests.
That is not really good. This is the current state for Scheme engravers. It
would be good to have some nice examples for Scheme engravers in the
documentation.
This particular case is, in my opinion, too complex for either documentation or
a targeted regtest. It is LSR material, or should become part of LilyPond
proper if one can think of a good way. Note that we have snippets in the
LilyPond documentation/repository as well: those can use the newest features.
That would be the proper place, I think.
We still need to get Scheme engravers into the main documentation.
The basic question is this: is this test helpful for programmers? At first
glance I'd say that it is, provided that you update the syntax as David
suggested.
IMO it takes a pretty silly example for something to *not* be a helpful test
case. Sure, having complicated scheme here might mean that future changes to
some scheme interfaces would need to update this file as well, but IMO that's a
perfectly legitimate function of a regtest!
Now, this test might be useful as a LSR snippet as well, so you may want to
consider sending it there (at least once LSR supports 2.16). Until that
happens, it could got to Documentation/snippets/new, but I recommend asking
James or Phil to handle that part of it.
Issue 5882053: Add an example implementation of cross-staff stems
Created 13 years ago by Pavel Roskin
Modified 13 years ago
Reviewers: dak, Graham Percival
Base URL: http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Comments: 1